Discussion:
Ruby style guide - update process
David Majda
2013-09-26 13:24:12 UTC
Permalink
Hi,

at the CSM Workshop at SUSE we discussed how to update the current SUSE
Ruby style guide [1] to reflect the experience we gained since its
introduction and also real-world Ruby usage. We agreed on the following:

1. The style guide should have a maintainer, who will be responsible
for its text and for processing and incorporating changes proposed
by others. Maintainer's decisions should generally reflect the
prevailing opinions of SUSE/openSUSE Ruby developers as they will
express them.

I volunteered to be such maintainer, which was accepted by
everyone present.

2. There should be a clear process to introduce changes, which would
allow everyone interested to participate, but which would also be
light-weight and which would not cause additional delays. The
process proposal we agreed on is outlined below.

3. SUSE Ruby developers will meet at future CSM Workshops whenever
they feel the need to discuss changes in the style guide in
person. Proposed changes resulting from such discussions will then
still go through the formal process like all other changes.

Please have a look at the process proposal and let me know if you have
any comments. After the discussion I'd like to put the final process
description into the style-guides repository. Then I'd like to use the
process to propose some specific changes to the specification, which we
also discussed at the CSM Workshop.

Thank you.

Style Guide Update Process
--------------------------

Anyone interested can propose a change to the Ruby style guide. Such
person is called an *initiator*. The process is as follows:

1. The initiator creates a pull request against the style guide on
GitHub with the proposed change.

2. The initiator announces the proposed change at:

- ruby-devel-***@public.gmane.org
- opensuse-ruby-***@public.gmane.org

3. SUSE/openSUSE Ruby developers will discuss the proposed change
(either at the pull request on GitHub, or in the mailing lists),
possibly expressing their agreement, disagreement and requests for
modifications. This discussion will be overseen by the maintainer,
who will work with the initiator to adapt the proposed change as
necessary.

4. Based on the discussion, the maintainer will decide either to
merge the pull request or reject it. He will announce his decision
as a reply to the original e-mail announcement of the proposed
change.

[1] https://github.com/SUSE/style-guides/blob/master/Ruby.md
--
David Majda
SUSE developer
Josef Reidinger
2013-09-26 13:47:49 UTC
Permalink
On Thu, 26 Sep 2013 15:24:12 +0200
Post by David Majda
Hi,
at the CSM Workshop at SUSE we discussed how to update the current
SUSE Ruby style guide [1] to reflect the experience we gained since
its introduction and also real-world Ruby usage. We agreed on the
1. The style guide should have a maintainer, who will be
responsible for its text and for processing and incorporating changes
proposed by others. Maintainer's decisions should generally reflect
the prevailing opinions of SUSE/openSUSE Ruby developers as they will
express them.
I volunteered to be such maintainer, which was accepted by
everyone present.
2. There should be a clear process to introduce changes, which
would allow everyone interested to participate, but which would also
be light-weight and which would not cause additional delays. The
process proposal we agreed on is outlined below.
3. SUSE Ruby developers will meet at future CSM Workshops whenever
they feel the need to discuss changes in the style guide in
person. Proposed changes resulting from such discussions will
then still go through the formal process like all other changes.
Please have a look at the process proposal and let me know if you
have any comments. After the discussion I'd like to put the final
process description into the style-guides repository. Then I'd like
to use the process to propose some specific changes to the
specification, which we also discussed at the CSM Workshop.
Thank you.
Style Guide Update Process
--------------------------
Anyone interested can propose a change to the Ruby style guide. Such
1. The initiator creates a pull request against the style guide on
GitHub with the proposed change.
Ugh why? and our internal ruby-devel that is intended mainly to discuss
legal, security or support issues is not accesible outside of suse for
community contributors. So I propose to use only opensuse ruby mailing
list.
Post by David Majda
3. SUSE/openSUSE Ruby developers will discuss the proposed change
(either at the pull request on GitHub, or in the mailing lists),
possibly expressing their agreement, disagreement and requests
for modifications. This discussion will be overseen by the maintainer,
who will work with the initiator to adapt the proposed change as
necessary.
I don't like to split discussion on various places. I think discussion
should happen on one place and github pull request sound better for me
then mailing list. So I propose to discuss it only on pull request.
Post by David Majda
4. Based on the discussion, the maintainer will decide either to
merge the pull request or reject it. He will announce his
decision as a reply to the original e-mail announcement of the
proposed change.
[1] https://github.com/SUSE/style-guides/blob/master/Ruby.md
Otherwise sounds good.

Josef
Dominik Bamberger
2013-09-26 14:01:12 UTC
Permalink
Hey,

Could you please tell me again why we don't just use an existing (and popular)
resource like this:

https://github.com/bbatsov/ruby-style-guide

Cheers,
Dominik
Post by Josef Reidinger
On Thu, 26 Sep 2013 15:24:12 +0200
Post by David Majda
Hi,
at the CSM Workshop at SUSE we discussed how to update the current
SUSE Ruby style guide [1] to reflect the experience we gained since
its introduction and also real-world Ruby usage. We agreed on the
1. The style guide should have a maintainer, who will be
responsible for its text and for processing and incorporating changes
proposed by others. Maintainer's decisions should generally reflect
the prevailing opinions of SUSE/openSUSE Ruby developers as they will
express them.
I volunteered to be such maintainer, which was accepted by
everyone present.
2. There should be a clear process to introduce changes, which
would allow everyone interested to participate, but which would also
be light-weight and which would not cause additional delays. The
process proposal we agreed on is outlined below.
3. SUSE Ruby developers will meet at future CSM Workshops whenever
they feel the need to discuss changes in the style guide in
person. Proposed changes resulting from such discussions will
then still go through the formal process like all other changes.
Please have a look at the process proposal and let me know if you
have any comments. After the discussion I'd like to put the final
process description into the style-guides repository. Then I'd like
to use the process to propose some specific changes to the
specification, which we also discussed at the CSM Workshop.
Thank you.
Style Guide Update Process
--------------------------
Anyone interested can propose a change to the Ruby style guide. Such
1. The initiator creates a pull request against the style guide on
GitHub with the proposed change.
Ugh why? and our internal ruby-devel that is intended mainly to discuss
legal, security or support issues is not accesible outside of suse for
community contributors. So I propose to use only opensuse ruby mailing
list.
Post by David Majda
3. SUSE/openSUSE Ruby developers will discuss the proposed change
(either at the pull request on GitHub, or in the mailing lists),
possibly expressing their agreement, disagreement and requests
for modifications. This discussion will be overseen by the maintainer,
who will work with the initiator to adapt the proposed change as
necessary.
I don't like to split discussion on various places. I think discussion
should happen on one place and github pull request sound better for me
then mailing list. So I propose to discuss it only on pull request.
Post by David Majda
4. Based on the discussion, the maintainer will decide either to
merge the pull request or reject it. He will announce his
decision as a reply to the original e-mail announcement of the
proposed change.
[1] https://github.com/SUSE/style-guides/blob/master/Ruby.md
Otherwise sounds good.
Josef
Adam Spiers
2013-09-26 14:20:41 UTC
Permalink
Post by Dominik Bamberger
Hey,
Could you please tell me again why we don't just use an existing (and popular)
https://github.com/bbatsov/ruby-style-guide
+1; let's not reinvent the wheel unless there's a really compelling
reason, especially when (open)SUSE Ruby code makes such heavy use of
community code (look at the size of d:l:r:e, for instance).

Continue reading on narkive:
Loading...